./miri improvements #2296
Merged
./miri improvements #2296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Jul 1, 2022
|
|
||
| ## Handle some commands early, since they should *not* alter the environment. | ||
| case "$COMMAND" in | ||
| many-seeds) |
Contributor
There was a problem hiding this comment.
what on earth is this syntax. I have no idea how bash works XD gonna have to trust you here
Member
Author
There was a problem hiding this comment.
😂 it's the same syntax we already use elsewhere ;) Think match COMMAND { "many-seeds" => ... }
Contributor
There was a problem hiding this comment.
yea I assumed that's what it is, but it looks so weird.
oli-obk
approved these changes
Jul 1, 2022
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit 9bc7938 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have needed to run something with many different seeds often enough that I would like an easier way to do it. ;) So now we have
./miri many-seeds.Also I made the script less dependent on the working directory, so calling it from a different directory should work properly now even if that other directory does not have the same rustup override as the one where Miri lives.