Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 1, 2022

Signed-off-by: InfRandomness infrandomness@gmail.com

@RalfJung
Copy link
Member

RalfJung commented Jul 1, 2022

The code looks good, but there should be a test. :)
Probably one of the existing tests needs this, it just needs to be enabled for FreeBSD.

@ghost ghost force-pushed the shim-error branch from abe42a5 to bbafd79 Compare July 1, 2022 16:41
Signed-off-by: InfRandomness <infrandomness@gmail.com>
@ghost ghost force-pushed the shim-error branch from bbafd79 to dca2bb6 Compare July 1, 2022 16:42
@ghost
Copy link
Author

ghost commented Jul 1, 2022

The code looks good, but there should be a test. :) Probably one of the existing tests needs this, it just needs to be enabled for FreeBSD.

current_dir_with_isolation does, but then we need a new pipeline?

@RalfJung
Copy link
Member

RalfJung commented Jul 1, 2022

Just add it to the list of tests at

miri/ci.sh

Line 63 in 5815d8d

MIRI_TEST_TARGET=x86_64-unknown-freebsd run_tests_minimal hello integer vec

@ghost
Copy link
Author

ghost commented Jul 1, 2022

Just add it to the list of tests at

miri/ci.sh

Line 63 in 5815d8d

MIRI_TEST_TARGET=x86_64-unknown-freebsd run_tests_minimal hello integer vec

oh, so that's what this is for !
Nice

Signed-off-by: InfRandomness <infrandomness@gmail.com>
@RalfJung
Copy link
Member

RalfJung commented Jul 1, 2022

Nice. :)
@bors r+

@bors
Copy link
Contributor

bors commented Jul 1, 2022

📌 Commit dc47649 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Jul 1, 2022

⌛ Testing commit dc47649 with merge c1a37b8...

@bors
Copy link
Contributor

bors commented Jul 1, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing c1a37b8 to master...

@bors bors merged commit c1a37b8 into rust-lang:master Jul 1, 2022
@ghost ghost deleted the shim-error branch July 1, 2022 18:26
github-actions bot pushed a commit that referenced this pull request Jun 14, 2025
rustdoc: Further improve chapters and sections on testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants