remove Windows TERM env var hack and -Zmiri-env-exclude #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Sep 20, 2022
|
Somehow the macOS runner keeps taking more than a second for a few lines of code?!? But this only started recently. Very strange. |
|
@bors r=oli-obk |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack should not be needed any more since rust-lang/rust#100206. And that also mostly removes the need for
-Zmiri-env-exclude-- if needed, users can still achieve the same by running(unset VAR; cargo miri test).I am keeping
-Zmiri-env-forwardsince it is still useful, e.g. to have RUST_BACKTRACE=full set in an otherwise deterministic execution.@rust-lang/miri any objections to removing
-Zmiri-env-exclude?