Implement thread parking for Windows #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
windows-parking
branch
from
9f4723b to
4ee0c8d
Compare
This was referenced Oct 28, 2022
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2022
update Miri Noteworthy PRs: - rust-lang/miri#2624 - rust-lang/miri#2626 - rust-lang/miri#2630 - rust-lang/miri#2631
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Nov 5, 2022
update Miri Noteworthy PRs: - rust-lang#2624 - rust-lang#2626 - rust-lang#2630 - rust-lang#2631
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 20, 2024
update Miri Noteworthy PRs: - rust-lang/miri#2624 - rust-lang/miri#2626 - rust-lang/miri#2630 - rust-lang/miri#2631
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
update Miri Noteworthy PRs: - rust-lang/miri#2624 - rust-lang/miri#2626 - rust-lang/miri#2630 - rust-lang/miri#2631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc #2628
Based on code by @drmeepster. However I adjusted
WakeByAddressSingle: I don't think the futex value is compared again after the thread is woken up. I see nothing in the Windows docs indicating such a comparison, and the Linux futex does not behave like that either. So we only check the value before sleeping, same as on Linux.