Stack borrows: weak protectors #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
changed the title
|
See rust-lang/unsafe-code-guidelines#377 for a conceptual description of this change. |
|
At least the liballoc tests all this pass with this patch. I doubt there will be a lot of breakage out there, but I guess @saethlin will see. ;) |
saethlin
reviewed
Nov 20, 2022
saethlin
reviewed
Nov 20, 2022
|
I'm happy with the implementation. Thanks for cleaning up all the unnecessary mutability along the way. |
|
@bors r=saethlin |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue described in rust-lang/unsafe-code-guidelines#376.