Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace 'locally built rustc' instructions by 'Miri in rustc' #2698

Merged
merged 1 commit into from
Nov 28, 2022
Merged

replace 'locally built rustc' instructions by 'Miri in rustc' #2698

merged 1 commit into from
Nov 28, 2022

Conversation

RalfJung
Copy link
Member

No description provided.

@RalfJung RalfJung requested a review from oli-obk November 27, 2022 08:52
@RalfJung RalfJung mentioned this pull request Nov 27, 2022
Closed
saethlin
saethlin reviewed Nov 27, 2022
View reviewed changes
CONTRIBUTING.md

```sh
rm -f .auto-everything .auto-toolchain
./x.py test miri --stage 0
Copy link
Member

@saethlin saethlin Nov 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this isn't mentioned in ./x.py test -h -v, it only lists src/tools/miri. Not sure if it is supposed to include just miri in that list. (I am just now learning I could have been running x test miri)

Copy link
Member Author

@RalfJung RalfJung Nov 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only fairly recently learned about these shortcuts and honestly have no idea why they work... but they are handy.^^
@jyn514 is that something we can rely on even if it's not listed in --help?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. x.py supports all suffixes, they don't have to be an exact match: https://github.com/rust-lang/rust/blob/454784afba5bf35b5ff14ada0e31265ad1d75e73/src/bootstrap/builder.rs#L193

@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2022

📌 Commit 75e040e has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 28, 2022

⌛ Testing commit 75e040e with merge 9622070...

@bors
Copy link
Contributor

bors commented Nov 28, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9622070 to master...

@bors bors merged commit 9622070 into rust-lang:master Nov 28, 2022
@jyn514 jyn514 mentioned this pull request Nov 30, 2022
Closed
@RalfJung RalfJung deleted the miri-in-rustc branch December 2, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saethlin saethlin saethlin left review comments

@jyn514 jyn514 jyn514 left review comments

@oli-obk oli-obk Awaiting requested review from oli-obk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @oli-obk @bors @saethlin @jyn514