refactor scheduler #2699
Merged
refactor scheduler #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
schedule-refactor
branch
from
e857123 to
2dbed74
Compare
saethlin
reviewed
Nov 27, 2022
saethlin
reviewed
Nov 27, 2022
RalfJung
force-pushed
the
schedule-refactor
branch
from
5175bb3 to
e60d5ad
Compare
RalfJung
force-pushed
the
schedule-refactor
branch
from
e60d5ad to
b3dd240
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the scheduler to use something akin to a generator -- a callback that will be invoked when the stack of a thread is empty, which has the chance to push a new stack frame or do other things and then indicates whether this thread is done, or should be scheduled again. (Unfortunately I think we cannot use actual generators here.) The interpreter loop is now a proper infinite loop, the only way to leave it is for some kind of interrupt to be triggered (represented as
InterpError) -- unifying how we handle 'exit when callingprocess::exit' and 'exit when main thread quits'.The last commit implements an alternative approach to #2660 using this new structure. Fixes #2629.