Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri-script and cargo-miri cleanups #3006

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 2, 2023

At least in an initial test, cmd!(Shell::new()?, "env") does show the full environment. Let's see what CI says.

@osiewicz why did you add this code to forward the host environment?

@osiewicz
Copy link
Contributor

osiewicz commented Aug 2, 2023

Hi,
Yeah, it might be redundant given that it was added quite early in the migration to xshell and not everything around environment variables worked fine back then. This was something I wanted to tackle during the final touchups to the Miri-script PR, though I was more-so focused on making CI green first.

@RalfJung RalfJung force-pushed the miri-script-shell branch from 9da38cd to f96c30d Compare August 2, 2023 18:47
@RalfJung RalfJung changed the title no need to forward all env vars miri-script and cargo-miri cleanups Aug 2, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Aug 2, 2023

Okay then, let's get rid of it. :) Please let me know if there is any other cleanup you had pending. :D

Also, this finally gets rid of that pesky set_var in cargo-miri. It wasn't even that hard. ;) Cc #2783

@bors r+

@bors
Copy link
Contributor

bors commented Aug 2, 2023

📌 Commit f96c30d has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 2, 2023

⌛ Testing commit f96c30d with merge 606adf9...

@RalfJung RalfJung mentioned this pull request Aug 2, 2023
@bors
Copy link
Contributor

bors commented Aug 2, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 606adf9 to master...

@bors bors merged commit 606adf9 into rust-lang:master Aug 2, 2023
@RalfJung RalfJung deleted the miri-script-shell branch August 3, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants