-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate -Zmiri-disable-abi-check #3071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
deprecate-disable-abi
branch
from
September 21, 2023 06:44
53d33b1
to
f0f762e
Compare
oli-obk
approved these changes
Sep 21, 2023
saethlin
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I am in favor
@bors r=oli-obk,saethlin |
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Mar 6, 2024
remove the ability to disable ABI checking This got deprecated in #3071, about half a year ago. `@rust-lang/miri` I think it's fine to remove this now.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Mar 9, 2024
remove the ability to disable ABI checking This got deprecated in rust-lang/miri#3071, about half a year ago. `@rust-lang/miri` I think it's fine to remove this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #1776 but I couldn't find any discussion or motivation.