Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tempfile crate on UNIX hosts #3240

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

Jefffrey
Copy link
Contributor

Reviving old PR: #2720

Attempted to apply the changes as suggested by #2720 (comment)

To fix tempfile to work for UNIX targets only and fall back to previous behaviour of only supporting default mode for Windows targets

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2023

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@Jefffrey Jefffrey marked this pull request as draft December 26, 2023 05:15
@Jefffrey Jefffrey changed the title Support for tempfile crate Support for tempfile crate on UNIX host Dec 27, 2023
@Jefffrey Jefffrey changed the title Support for tempfile crate on UNIX host Support for tempfile crate on UNIX hosts Dec 27, 2023
@Jefffrey Jefffrey marked this pull request as ready for review December 27, 2023 04:15
@RalfJung
Copy link
Member

Looks good, thanks!

Could you please squash this into a single commit? (Or two commits, one by Pointerbender and one by you)

Co-authored-by: Jefffrey <22608443+Jefffrey@users.noreply.github.com>
Co-authored-by: Ralf Jung <post@ralfj.de>
@Jefffrey
Copy link
Contributor Author

Squashed to single commit

@RalfJung
Copy link
Member

Thanks. :)

@bors r+

@bors
Copy link
Contributor

bors commented Dec 27, 2023

📌 Commit 06add70 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 27, 2023

⌛ Testing commit 06add70 with merge fe1a722...

@bors
Copy link
Contributor

bors commented Dec 27, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing fe1a722 to master...

@bors bors merged commit fe1a722 into rust-lang:master Dec 27, 2023
@Jefffrey Jefffrey deleted the tempfile branch December 27, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants