-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tempfile crate on UNIX hosts #3240
Conversation
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
Looks good, thanks! Could you please squash this into a single commit? (Or two commits, one by Pointerbender and one by you) |
Co-authored-by: Jefffrey <22608443+Jefffrey@users.noreply.github.com> Co-authored-by: Ralf Jung <post@ralfj.de>
Squashed to single commit |
Thanks. :) @bors r+ |
☀️ Test successful - checks-actions |
Reviving old PR: #2720
Attempted to apply the changes as suggested by #2720 (comment)
To fix tempfile to work for UNIX targets only and fall back to previous behaviour of only supporting default mode for Windows targets