explain time-with-isolation test better #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
time-with-isolation
branch
from
f1d8f15 to
31f2ecd
Compare
saethlin
reviewed
Mar 14, 2024
| @@ -0,0 +1,2 @@ | |||
| The loop took around 7s | |||
| (It's fine for this number to change a bit when you `--bless` this test.) | |||
There was a problem hiding this comment.
How much is "a bit"? The recent rust-lang/rust PR changed this number from 7 to 12 which is quite a large swing normally, but per the comment in the source code within an order of magnitude is fine.
So probably we should say "within an order of magnitude" here if that is our expectation.
There was a problem hiding this comment.
We can also just say "it is okay to change"; we'll get pinged anyway when it happens so we can intervene if something seems to go terribly wrong.
RalfJung
force-pushed
the
time-with-isolation
branch
from
31f2ecd to
f0c8848
Compare
|
r=me |
|
@bors r=saethlin (Btw, you should have "r+" powers here. :) |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3377
@saethlin do you think this is better?