- 
                Notifications
    
You must be signed in to change notification settings  - Fork 401
 
Rustup, aligned heap-allocations on wasm #3606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …ter-len, r=c410-f3r,joshtriplett,joshtriplett
Rename `${length()}` to `${len()}`
Implements the rename suggested in rust-lang/rust#122808 (comment)
> I brought this up in the doc PR but it belongs here – `length` should probably be renamed `len` before stabilization. The latter is de facto standard in the standard library, whereas the former is only used in a single unstable API. These metafunctions aren’t library items of course, but should presumably still be consistent with established names.
r? `@c410-f3r`
    | 
           @bors r+  | 
    
    
  bors 
      added a commit
      that referenced
      this pull request
    
      May 16, 2024 
    
    
      
  
    
      
    
  
Rustup Pulls in rust-lang/rust#125003 so allocation tests should now work on wasm.
b541e46    to
    b97bbf5      
    Compare
  
    | 
           @bors r+ retry  | 
    
    
  bors 
      added a commit
      that referenced
      this pull request
    
      May 16, 2024 
    
    
      
  
    
      
    
  
Rustup, aligned heap-allocations on wasm Pulls in rust-lang/rust#125003 so allocation tests should now work on wasm.
| 
           @bors r+ retry  | 
    
| 
           ☀️ Test successful - checks-actions  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Pulls in rust-lang/rust#125003 so allocation tests should now work on wasm.