Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implements arc4random_buf shim for freebsd/solarish platforms. #3918

Merged
merged 2 commits into from
Sep 28, 2024
Merged

implements arc4random_buf shim for freebsd/solarish platforms. #3918

merged 2 commits into from
Sep 28, 2024

Conversation

devnexen
Copy link
Contributor

close #3914

@devnexen devnexen force-pushed the solaris_arc4random_buf branch from eea42eb to a73d8b7 Compare September 26, 2024 18:56
@RalfJung
Copy link
Member

Thanks a lot for the quick PR :)

@RalfJung RalfJung added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Sep 28, 2024
@devnexen devnexen force-pushed the solaris_arc4random_buf branch 3 times, most recently from 9781e23 to 2271e77 Compare September 28, 2024 16:01
@devnexen devnexen force-pushed the solaris_arc4random_buf branch from 2271e77 to a4565a6 Compare September 28, 2024 18:08
@devnexen devnexen force-pushed the solaris_arc4random_buf branch from a4565a6 to 3fec800 Compare September 28, 2024 19:03
@RalfJung
Copy link
Member

I will take the liberty yo make this as "ready for review".

@RalfJung RalfJung marked this pull request as ready for review September 28, 2024 19:03
@RalfJung
Copy link
Member

Looks good, thanks. :)
@bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2024

📌 Commit 680c321 has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request Sep 28, 2024
@bors
Auto merge of #3918 - devnexen:solaris_arc4random_buf, r=RalfJung
0b177c1 
implements arc4random_buf shim for freebsd/solarish platforms.

close #3914
@bors
Copy link
Contributor

bors commented Sep 28, 2024

⌛ Testing commit 680c321 with merge 0b177c1...

@bors
Copy link
Contributor

bors commented Sep 28, 2024

💔 Test failed - checks-actions

@RalfJung RalfJung force-pushed the solaris_arc4random_buf branch from 680c321 to bd31591 Compare September 28, 2024 19:34
@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2024

📌 Commit bd31591 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 28, 2024

⌛ Testing commit bd31591 with merge 6f199e7...

@bors
Copy link
Contributor

bors commented Sep 28, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 6f199e7 to master...

@bors bors merged commit 6f199e7 into rust-lang:master Sep 28, 2024
8 checks passed
@bors bors mentioned this pull request Sep 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: Waiting for the PR author to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement arc4random_buf for FreeBSD, Solarish
3 participants
@devnexen @RalfJung @bors