Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames EvalContext to InterpretCx #668

Merged
merged 3 commits into from
Mar 30, 2019
Merged

Renames EvalContext to InterpretCx #668

merged 3 commits into from
Mar 30, 2019

Conversation

kenta7777
Copy link
Contributor

This PR renames EvalContext to InterpretCx due to the change.

@RalfJung RalfJung added the S-blocked-on-rust Status: Blocked on landing a Rust PR label Mar 27, 2019
@kenta7777
Copy link
Contributor Author

The change have merged now.

@oli-obk oli-obk closed this Mar 28, 2019
@oli-obk oli-obk reopened this Mar 28, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 28, 2019

we'll need to wait for tomorrow's nightly

@RalfJung RalfJung added S-waiting-on-nightly and removed S-blocked-on-rust Status: Blocked on landing a Rust PR labels Mar 28, 2019
@RalfJung RalfJung mentioned this pull request Mar 28, 2019
Closed
@RalfJung
Copy link
Member

@kenta7777 could you (a) rebase on top of current master, and (b) adjust rust-version to the latest nightly (2019-03-29)? Then CI should be green and we can land this PR.

@RalfJung RalfJung added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-nightly labels Mar 29, 2019
@kenta7777 kenta7777 force-pushed the rename-evalcontext-to-interpretcx branch from 326961a to adbda8c Compare March 30, 2019 02:03
@RalfJung
Copy link
Member

Not sure why
83b7f2e is now pat of this, seems like something went wrong rebasing... but whatever, merging.

Thanks!

@RalfJung RalfJung merged commit ac61d29 into rust-lang:master Mar 30, 2019
@kenta7777
Copy link
Contributor Author

Thanks!

@kenta7777 kenta7777 deleted the rename-evalcontext-to-interpretcx branch April 1, 2019 12:40
@kenta7777 kenta7777 mentioned this pull request Apr 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: Waiting for the PR author to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenta7777 @oli-obk @RalfJung @0xflotus