Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator, async tests with uninhabited saved local #896

Merged
merged 1 commit into from
Aug 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions tests/run-pass/async-fn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,32 @@ pub async fn foo(x: &u32, y: u32) -> u32 {
*x + y + *a
}

async fn add(x: u32, y: u32) -> u32 {
async { x + y }.await
}

async fn build_aggregate(a: u32, b: u32, c: u32, d: u32) -> u32 {
let x = (add(a, b).await, add(c, d).await);
x.0 + x.1
}

enum Never {}
fn never() -> Never {
panic!()
}

async fn includes_never(crash: bool, x: u32) -> u32 {
let mut result = async { x * x }.await;
if !crash {
return result;
}
#[allow(unused)]
let bad = never();
result *= async { x + x }.await;
drop(bad);
result
}

fn raw_waker_clone(_this: *const ()) -> RawWaker {
panic!("unimplemented");
}
Expand All @@ -38,4 +64,14 @@ fn main() {
let waker = unsafe { Waker::from_raw(RawWaker::new(ptr::null(), &RAW_WAKER)) };
let mut context = Context::from_waker(&waker);
assert_eq!(unsafe { Pin::new_unchecked(&mut fut) }.poll(&mut context), Poll::Ready(31));

let mut fut = build_aggregate(1, 2, 3, 4);
let waker = unsafe { Waker::from_raw(RawWaker::new(ptr::null(), &RAW_WAKER)) };
let mut context = Context::from_waker(&waker);
assert_eq!(unsafe { Pin::new_unchecked(&mut fut) }.poll(&mut context), Poll::Ready(10));

let mut fut = includes_never(false, 4);
let waker = unsafe { Waker::from_raw(RawWaker::new(ptr::null(), &RAW_WAKER)) };
let mut context = Context::from_waker(&waker);
assert_eq!(unsafe { Pin::new_unchecked(&mut fut) }.poll(&mut context), Poll::Ready(16));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to move the common parts of these three "run an async fn" tests into a helper function?

I can also do that after landing, though.

}
13 changes: 13 additions & 0 deletions tests/run-pass/generator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@ fn finish<T>(mut amt: usize, mut t: T) -> T::Return
}
}
}
}

enum Never {}
fn never() -> Never {
panic!()
}

fn main() {
Expand Down Expand Up @@ -67,4 +71,13 @@ fn main() {
}),
10
);
let b = true;
finish(1, || {
yield 1;
if b { return; }
#[allow(unused)]
let x = never();
yield 2;
drop(x);
});
}