Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getcwd shim #958

Merged
merged 7 commits into from
Sep 24, 2019
Merged

Add getcwd shim #958

merged 7 commits into from
Sep 24, 2019

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 18, 2019

No description provided.

oli-obk
oli-obk reviewed Sep 18, 2019
View reviewed changes
src/helpers.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk reviewed Sep 18, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk reviewed Sep 18, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
@pvdrz pvdrz closed this Sep 18, 2019
@pvdrz pvdrz reopened this Sep 18, 2019
oli-obk
oli-obk requested changes Sep 20, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
src/shims/env.rs Outdated Show resolved Hide resolved
src/shims/env.rs Outdated Show resolved Hide resolved
src/shims/env.rs Outdated Show resolved Hide resolved
@pvdrz pvdrz requested a review from oli-obk September 20, 2019 07:57
oli-obk
oli-obk reviewed Sep 20, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
@pvdrz
Copy link
Contributor Author

pvdrz commented Sep 20, 2019

I checked the getcwd implementation and it always generates an error from errno so the unwrap should never fail

bjorn3
bjorn3 reviewed Sep 20, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk reviewed Sep 20, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
oli-obk
oli-obk requested changes Sep 24, 2019
View reviewed changes
src/shims/env.rs Outdated Show resolved Hide resolved
src/shims/env.rs Outdated Show resolved Hide resolved
@pvdrz pvdrz requested a review from oli-obk September 24, 2019 14:30
@oli-obk
Copy link
Contributor

oli-obk commented Sep 24, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2019

📌 Commit 02261e4 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Sep 24, 2019

⌛ Testing commit 02261e4 with merge 2e17933...

bors added a commit that referenced this pull request Sep 24, 2019
@bors
Auto merge of #958 - christianpoveda:getcwd-shim, r=oli-obk
2e17933 
Add getcwd shim
@bors
Copy link
Contributor

bors commented Sep 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 2e17933 to master...

@bors bors merged commit 02261e4 into rust-lang:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk Awaiting requested review from oli-obk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pvdrz @oli-obk @bors @RalfJung @bjorn3