Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chdir shim #960

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Add chdir shim #960

merged 2 commits into from
Sep 24, 2019

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 24, 2019

oli-obk
oli-obk requested changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a compile-fail test showing that we error for non-utf8 paths by invoking chdir directly from the test

src/shims/env.rs Outdated Show resolved Hide resolved
@pvdrz
Copy link
Contributor Author

pvdrz commented Sep 24, 2019

please add a compile-fail test showing that we error for non-utf8 paths by invoking chdir directly from the test

OK I added the test :)

@oli-obk
Copy link
Contributor

oli-obk commented Sep 24, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2019

📌 Commit 145a582 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Sep 24, 2019

⌛ Testing commit 145a582 with merge 402129c...

bors added a commit that referenced this pull request Sep 24, 2019
@bors
Auto merge of #960 - christianpoveda:chdir-shim, r=oli-obk
402129c 
Add `chdir` shim

r? @oli-obk
@bors
Copy link
Contributor

bors commented Sep 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 402129c to master...

@bors bors merged commit 145a582 into rust-lang:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pvdrz @oli-obk @bors @RalfJung