-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to error with enabled isolation #996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
changed the title
Add function to panic with enabled isolation
Add function to error with enabled isolation
Oct 14, 2019
RalfJung
reviewed
Oct 14, 2019
RalfJung
reviewed
Oct 14, 2019
pvdrz
force-pushed
the
unsup-wo-isolation
branch
from
October 14, 2019 21:55
3c17839
to
2931c87
Compare
Looking good! Please rebase across #975 once that landed to also use this for the clock shims. |
☔ The latest upstream changes (presumably #975) made this pull request unmergeable. Please resolve the merge conflicts. |
pvdrz
force-pushed
the
unsup-wo-isolation
branch
from
October 15, 2019 12:33
2931c87
to
78311a7
Compare
OK we are good to go |
Thanks! @bors r+ |
📌 Commit 78311a7 has been approved by |
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986
r? @RalfJung