Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite "Implementing Vec" chapter - Unique is permanently unstable #160

Closed
tesuji opened this issue Aug 24, 2019 · 2 comments · Fixed by #223
Closed

Rewrite "Implementing Vec" chapter - Unique is permanently unstable #160

tesuji opened this issue Aug 24, 2019 · 2 comments · Fixed by #223

Comments

@tesuji
Copy link
Contributor

tesuji commented Aug 24, 2019 •
edited
Loading

This chapter use Unique to demonstrate how to implement a Vec. But it is
permanently unstable and can only be used by std. Also in
https://github.com/rust-lang/rust/blob/478464570e60523adc6d303577d1782229ca1f93/src/libcore/ptr/unique.rs#L28-L34
it recommends that we should use NonNull instead and consider PhantomData<T>.
@eisterman
Copy link

What is the pattern to use instead of Unique? With NonNull?

@Coder-256
Copy link

I think this is a duplicate of #83.

@SNCPlay42 SNCPlay42 mentioned this issue Apr 30, 2020
Closed
@blkerby blkerby mentioned this issue Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust Vec to build on stable Rust blkerby/nomicon
3 participants
@eisterman @Coder-256 @tesuji