Write a basic "call Rust from C" example #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Aug 20, 2021
src/ffi.md
Outdated
| ``` | ||
|
|
||
| The `extern "C"` makes this function adhere to the C calling convention, as discussed above in "[Foreign Calling Conventions]". | ||
| The `no_mangle` attribute turns off Rust's name mangling, so that it is easier to link to. |
There was a problem hiding this comment.
Suggested change
| The `no_mangle` attribute turns off Rust's name mangling, so that it is easier to link to. | |
| The `no_mangle` attribute turns off Rust's name mangling, so that it has a well defined symbol to link to. |
I realize you just moved this from below, but the way it is written seems strange to me. With a mangled name, I don't think you'd be able to guess the symbol name at all, which makes linking mostly impossible?
There was a problem hiding this comment.
I moved it because we have the "Callbacks from C code to Rust functions" section below. Applied your suggestion, is it okay with you now?
|
FWIW, this chapter seems to be getting quite long. At some point it might be worthwhile to consider breaking it up. |
JohnTitor
force-pushed
the
call-rust-code-from-c
branch
from
4f56020 to
88b2dbc
Compare
|
Sorry for the huge delay! I applied your comments.
Sounds good, I'll do it on another PR not to make this PR large. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2021
Update books ## nomicon 3 commits in 2d66852a27c5d0ec50ae021820d1de22caa2b1bd..358e6a61d5f4f0496d0a81e70cdcd25d05307342 2021-10-07 19:00:37 +0900 to 2021-10-20 11:23:12 -0700 - Write a basic "call Rust from C" example (rust-lang/nomicon#296) - Clarify the Safe vs. Unsafe Rust relationship (rust-lang/nomicon#294) - Fix typo with respect to dangling pointer (rust-lang/nomicon#319) ## book 8 commits in eb1282ec444db94055fa9531b6f3f803e86bb382..fd9299792852c9a368cb236748781852f75cdac6 2021-09-16 21:17:09 -0400 to 2021-10-22 21:59:46 -0400 - Reword description to emphasize what return does in a match arm - Correct backwards wording describing From impls. Fixes rust-lang/book#2829 - Remove multiple negatives, add examples. Fixes rust-lang/book#2833 - Fix capitalization in sidebar. Fixes rust-lang/book#2860 - fix quotes - comments from nostarch and responses for chapter 2 - (rust-lang/book#2906) - Merge pull request rust-lang/book#2892 from Enrico2/patch-1 ## rust-by-example 1 commits in 9a60624fcad0140826c44389571dc622917cd632..27f1ff5e440ef78828b68ab882b98e1b10d9af32 2021-10-04 08:13:53 -0300 to 2021-10-13 08:04:40 -0300 - Added example of `impl Trait` as an argument (rust-lang/rust-by-example#1468) ## embedded-book 1 commits in 270fccd339e5972d9c900e788f197e81a0bcd956..51739471276b1776dea27cf562b974ef07e24685 2021-10-06 16:28:48 +0000 to 2021-10-17 16:48:42 +0000 - Fix typo in 'The Borrow Checker' (rust-embedded/book#305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #138
I'm not sure if this is the simplest way but should make it easy to understand.