Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The unique feature is renamed ptr_internals #48

Merged
merged 4 commits into from
Jan 21, 2018
Merged

The unique feature is renamed ptr_internals #48

merged 4 commits into from
Jan 21, 2018

Conversation

SimonSapin
Copy link
Contributor

This PR and rust-lang/rust#46952 mutually depend on each other.

@SimonSapin
Copy link
Contributor Author

@gankro you said that Unique is destined to never being stabilized and only staying as an implementation detail of the standard library. This rename is on that basis.

Perhaps sections of the Nomicon using Unique should eventually be rewritten to use NonNull? I suppose this depends on whether you want to explain how std works, or how one would go about writing their own collection.

@SimonSapin SimonSapin mentioned this pull request Dec 22, 2017
Merged
@SimonSapin
Copy link
Contributor Author

SimonSapin commented Jan 21, 2018 •
edited
Loading

With today’s Nightly this should now pass tests.

@Gankra Gankra merged commit b5e784d into rust-lang:master Jan 21, 2018
@SimonSapin SimonSapin deleted the unique branch January 22, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gankra Gankra Gankra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonSapin @Gankra @steveklabnik