Fixed of compilation on latest nightly locally, but still issue on playg…

[izderadicka]

Fixing #70, works fine with local nightly, but but looks like very latest nightly has changed again.

[izderadicka]

Look like it now works with System allocator - I'm really confused by those changes - which allocator is which now and which to use?

[Gankra]

r? @SimonSapin

…

On Wed, Jun 13, 2018 at 3:26 PM, Ivan Zderadicka ***@***.***> wrote: Look like it now works with System allocator - I'm really confused by those changes - which allocator is which now and which to use? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFY4PJrmFK2ZaGzBYbOQ9D1ErvYp4fQks5t8S9DgaJpZM4Ul8JQ> .

[RalfJung]

Seems like #73 did the same thing and hence broke this PR?

[izderadicka]

@RalfJung yes I think it's almost the same except two things:

1. I think there is logical error in Drain as both Iterator and DoubleEndedIterator impl are using next_back from underlying iterator- so both going in same direction - backwards.
2. I added some tests to vec-final.

Remainig diffs are just formating ( and I used System instead of Global but Global seems to be right name now).
If you're interested in two changes mentioned above let me know I'll pull latest version and leave just these two.

[RalfJung]

I think there is logical error in Drain as both Iterator and DoubleEndedIterator impl are using next_back from underlying iterator- so both going in same direction - backwards.

That looks like a typo indeed but it was not introduced by #73. I'd prefer if @gankro would take a look.^^

I added some tests to vec-final.

I'm always in favor of tests. :D Do you know if mdbook test will run these tests?

[Gankra]

CC @steveklabnik on mdbook

[steveklabnik]

mdbook test runs rustdoc --test on each of your files, so it should.

[RalfJung]

So @izderadicka would you like to make a new PR with your tests, and with the fix to next_back (that is likely needed to make the tests pass)?

[izderadicka]

@RalfJung will look at it next week as I'm off this week. Closing this one.