Skip to content

Endianness was incorrectly assumed for GroupWord #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Endianness was incorrectly assumed for GroupWord #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abbbb20
fix: Endianness was incorrectly assumed for GroupWord
Erk- Oct 25, 2021
05b5cd0
Use the solution suggested by cuviper
Erk- Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/swisstable_group_query/no_simd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ impl GroupQuery {
let cmp = group ^ repeat(h2);
let high_bit_greater_than_128 = (!cmp) & repeat(0x80);
let high_bit_greater_than_128_or_zero = cmp.wrapping_sub(repeat(0x01));
let eq_mask = (high_bit_greater_than_128_or_zero & high_bit_greater_than_128).to_le();
let eq_mask = high_bit_greater_than_128_or_zero & high_bit_greater_than_128;

let empty_mask = (group & repeat(0x80)).to_le();
let empty_mask = group & repeat(0x80);

GroupQuery {
eq_mask,
Expand Down