Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy lints #272

Merged
merged 7 commits into from
Sep 23, 2020
Merged

Fix Clippy lints #272

merged 7 commits into from
Sep 23, 2020

Conversation

GabrielMajeri
Copy link
Contributor

This PR attempts to get CI to work again by fixing Clippy lints.

@GabrielMajeri
Copy link
Contributor Author

It seems it still doesn't build currently because of the core_simd dependency

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 30, 2019

I see :/

@mati865
Copy link
Contributor

mati865 commented Oct 29, 2019

Core_arch was fixed recently but there is no new version yet, you could try patching Cargo.toml to use git version.

@GabrielMajeri
Copy link
Contributor Author

Well this is just lovely. While trying to still fix the build I managed to get an ICE...

error: internal compiler error: src/librustc_mir/transform/qualify_consts.rs:1145: promotion candidate validation mismatches (see above)

I think it's going to take a while until we get CI working again...

@mati865
Copy link
Contributor

mati865 commented Oct 31, 2019

There are no reports of this ICE in Rust repo. Can you temporary add RUST_BACKTRACE=1 to the CI job and report it upstream?

@ecstatic-morse
Copy link
Contributor

@GabrielMajeri rust-lang/rust#66016 should be fixed in the next nightly release. Thanks for reporting this BTW.

@mati865
Copy link
Contributor

mati865 commented Nov 13, 2019

Clippy is green now, probably core_arch needs new release.

@workingjubilee
Copy link
Member

This looks lovely! I know you wanted to fix CI with this but this looks like it fixes everything that is still blocking #292 so I'm going to merge it.

@workingjubilee workingjubilee merged commit 065021d into rust-lang:master Sep 23, 2020
@GabrielMajeri GabrielMajeri deleted the fix-clippy branch September 24, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants