-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clippy lints #272
Fix Clippy lints #272
Conversation
It seems it still doesn't build currently because of the core_simd dependency |
I see :/ |
Core_arch was fixed recently but there is no new version yet, you could try patching Cargo.toml to use git version. |
# Conflicts: # Cargo.toml
1717bb7
to
e333526
Compare
62d3317
to
d17a6a8
Compare
Well this is just lovely. While trying to still fix the build I managed to get an ICE...
I think it's going to take a while until we get CI working again... |
There are no reports of this ICE in Rust repo. Can you temporary add |
a8eb526
to
7d16da1
Compare
@GabrielMajeri rust-lang/rust#66016 should be fixed in the next nightly release. Thanks for reporting this BTW. |
7d16da1
to
d17a6a8
Compare
Clippy is green now, probably |
This looks lovely! I know you wanted to fix CI with this but this looks like it fixes everything that is still blocking #292 so I'm going to merge it. |
This PR attempts to get CI to work again by fixing Clippy lints.