Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.5: Get current with rustc const generics #322

Merged
merged 4 commits into from
May 16, 2021
Merged

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented May 16, 2021

This PR fixes the build for packed_simd_2, now 0.3.5, with the current nightly, for all major platforms. This is motivated by several internal changes to how rustc handles const arguments, as packed_simd is an avid consumer of the hidden dragons inside rustc's internal APIs and so the breakage affects packed_simd.

There should be no external API changes, though the change in the shuffle macros may hypothetically complicate life for users if there is some hidden complexity involving expansion and the usage of const generics in the API. This is considered a wholly acceptable breakage if it does occur. Barring that, a user should be able to build this version of packed_simd if they are up to date with at least:

packed_simd> rustc --version
rustc 1.54.0-nightly (8cf990c9b 2021-05-15)

The later commits also kill clippy checks and #[deny(warnings)] cases on the examples because keeping up with those is an unacceptable drag on maintenance at this late stage of the game. However, the warnings do indicate there is an unsound code pattern somewhere inside these examples or inside packed_simd. aobench is the one I first noticed this warning within, but it is endemic to the examples.

Hopefully the Portable SIMD API group (et moi) manages to land core::simd before I need to do another maintenance release like this, so I can just tell people to move to that instead.

@workingjubilee workingjubilee force-pushed the get-current branch 2 times, most recently from 984d0a8 to 7dae423 Compare May 16, 2021 04:06
src/lib.rs Outdated Show resolved Hide resolved
@workingjubilee workingjubilee force-pushed the get-current branch 2 times, most recently from a782324 to bea31ee Compare May 16, 2021 19:39
@workingjubilee workingjubilee changed the title Get current with rustc const generics 0.3.5: Get current with rustc const generics May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants