Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more doctests #132

Closed
wants to merge 5 commits into from
Closed

add more doctests #132

wants to merge 5 commits into from

Conversation

miguelraz
Copy link
Contributor

@miguelraz miguelraz commented Jun 5, 2021 •
edited
Loading

DO NOT MERGE - WIP
As well as

  • clarify that rounding ties away from zero, as is usual in Rust
  • comment on wrapping addition for horizontal_sum() on floats

@programmerjake
Copy link
Member

See also: The debate on if we should use the slow C round semantics or use the ties-to-even semantics that are generally faster due to better cpu support:
rust-lang/rust#55107

@miguelraz
Copy link
Contributor Author

@programmerjake ooooh, thanks for the link!

@calebzulawski calebzulawski marked this pull request as draft June 13, 2021 18:13
@workingjubilee
Copy link
Member

This PR was unfortunately disrupted by many internal rearrangements. My apologies.
I think it would be good if you wanted to reopen with an updated version but I am closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelraz @programmerjake @workingjubilee