Add bitmask array #246
Merged
Add bitmask array #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
feature/bitmask_array
branch
from
051e1b6 to
8a9f0bb
Compare
workingjubilee
added a commit
that referenced
this pull request
Feb 26, 2022
Another approach that fixes #223, as an alternative to #238. This adds the `ToBitMask` trait, which is implemented on a vector for each bitmask type it supports. This includes all unsigned integers with enough bits to contain it. The byte array variant has been separated out for now into #246 and still requires `generic_const_exprs`, but the integer variants no longer require it and can make it to nightly.
workingjubilee
force-pushed
the
feature/bitmask_array
branch
from
8a9f0bb to
8f108a7
Compare
|
Aaaand my condolences. |
calebzulawski
force-pushed
the
feature/bitmask_array
branch
from
8f108a7 to
1cee930
Compare
|
Ok, the problem was just not gating enough on the |
programmerjake
requested changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on the somewhat problematic feature from #239 (based on that branch).