Closed
Conversation
thomcc
reviewed
Jun 6, 2022
Member
There was a problem hiding this comment.
I'm not sure this makes that much sense as a public method (although I'm not sure it's not worth having, it just seems a little specific of a shuffle), but I do think it's worth using inside splat if it's needed to fix https://rust-lang.zulipchat.com/#narrow/stream/257879-project-portable-simd/topic/Very.20bad.20.60u16x8.3A.3Asplat.60.20codegen.20on.20x86_64
Member
programmerjake
left a comment
There was a problem hiding this comment.
idk that we should have splat_lane as a public API, considering how easy it is to do:
pub fn splat_lane_0(v: u16x8) -> u16x8
{
simd_swizzle!(v, [0; 8])
}other than that, lgtm.
Member
Author
|
I suppose it is pretty trivial with the macro, agreed. Trivial enough to add in the future if requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like splat, but from an existing vector.