Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Fix Firefox icon, onclick icon, whitespace #37

Merged
merged 4 commits into from
Jun 17, 2014

Conversation

jasonkliu
Copy link
Contributor

This is a continuation of the pull #35.
The icon pulled from Fontello did not work using the svg font, so it was replaced with a woff font.
In addition, the issue with the broken playground link was resolved as follows:

  • The icon has no href in the html file.
  • When a successful run or error message is shown, the output is displayed as well as the icon (still with no href).
  • When the icon is clicked, it calls the javascript function goPlayground() which loads the contents of the editor, encodes the URL, and navigates to the playground.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The whitespace is now 4 spaces for leading <div> tags and two spaces for indentations.
In addition, tabs were removed and replaced with spaces.
brson added a commit that referenced this pull request Jun 17, 2014
Fix Firefox icon, onclick icon, whitespace
@brson brson merged commit 3d124b0 into rust-lang:gh-pages Jun 17, 2014
@brson
Copy link
Contributor

brson commented Jun 17, 2014

Thanks for the quick update!

@jasonkliu
Copy link
Contributor Author

No problem, I was able to fix all of the issues. I was looking at the problem the wrong way initially and didn't know that a solution was available as described above. Thanks for merging!

@jasonkliu jasonkliu deleted the 14652_frontpage_style branch June 17, 2014 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants