Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Tie use of feature to the current edition #43

Closed
nikomatsakis opened this issue Feb 17, 2021 · 6 comments
Closed

Tie use of feature to the current edition #43

nikomatsakis opened this issue Feb 17, 2021 · 6 comments
Assignees
@arora-aman
Labels
bug Something isn't working
Milestone
Feature complete

Comments

@nikomatsakis
Copy link
Contributor

Today we use the #![feature] to decide whether to use new-style capture, but we should also consider the 2021 edition.
@nikomatsakis nikomatsakis added the bug Something isn't working label Feb 17, 2021
@arora-aman
Copy link
Member

  • We'd probably want to look into tying the lint to edition as well

@m-ou-se
Copy link
Member

m-ou-se commented Jun 7, 2021

Is there anything blocking this?

@nikomatsakis
Copy link
Contributor Author

I'm going to assign this to @arora-aman -- feel free to reassign.

@arora-aman
Copy link
Member

  • Feature enabled by default on edition 2021
  • Set future incompabile in lint metadata to edition 2021

@arora-aman arora-aman mentioned this issue Jun 22, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jun 24, 2021
@JohnTitor
Rollup merge of rust-lang#86536 - sexxi-goose:edition, r=nikomatsakis
3998c03 
Edition 2021 enables disjoint capture

First part for rust-lang/project-rfc-2229#43
@m-ou-se
Copy link
Member

m-ou-se commented Jun 27, 2021 •
edited
Loading

For the lint:

@m-ou-se m-ou-se mentioned this issue Jun 27, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jun 28, 2021
@JohnTitor
Rollup merge of rust-lang#86673 - m-ou-se:disjoint-capture-edition-li…
af3c154 
…nt, r=nikomatsakis

Make disjoint_capture_migration an edition lint.

This turns the disjoint capture lint into an edition lint, and changes all the wording to refer to the edition.

This includes the same first commit as rust-lang#86671. See rust-lang#86671.

Fixes most of rust-lang/project-rfc-2229#43 (comment)
@nikomatsakis
Copy link
Contributor Author

This is now done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arora-aman arora-aman

Labels
bug Something isn't working
Projects
None yet
Milestone
Feature complete
Development

No branches or pull requests
3 participants
@nikomatsakis @m-ou-se @arora-aman