Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

break out the upvar code into modules #55

Open
nikomatsakis opened this issue Jul 9, 2021 · 0 comments
Open

break out the upvar code into modules #55

nikomatsakis opened this issue Jul 9, 2021 · 0 comments

Comments

@nikomatsakis
Copy link
Contributor

I think this code would be cleaner if we made an upvar module with submodules like:

  • rustc_typeck::check::upvar::collect_uses
  • rustc_typeck::check::upvar::minimization

and just had the "top-level logic" in rustc_typeck::check::upvar.

I also think we should include a comment with the "abstract algorithm" -- but maybe it should live in the reference, actually, and we should just reference to it from here.

Originally posted by @nikomatsakis in rust-lang/rust#86995 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant