2229: Rewrite/Refactor Closure Capture Analaysis #86995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
arora-aman
commented
Jul 9, 2021
nikomatsakis
requested changes
Jul 9, 2021
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
nikomatsakis
approved these changes
Jul 11, 2021
|
@bors r+ |
|
📌 Commit 5055569 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While handling all the differnet edge cases the code for the captur analysis got pretty compicated. Looking at the overall picture of the edge cases the rules can still be layed out simply.
Alogithm: https://hackmd.io/D3I_gwvuT-SPnJ22tgJumw
r? @nikomatsakis
Closes rust-lang/project-rfc-2229#52
Implementation part of rust-lang/project-rfc-2229#53