Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Write specification for Capture Analysis #53

Open
arora-aman opened this issue Jun 30, 2021 · 1 comment
Open

Write specification for Capture Analysis #53

arora-aman opened this issue Jun 30, 2021 · 1 comment
Assignees
@arora-aman

Comments

@arora-aman
Copy link
Member

Over the last year of iterations for edge cases, the capture analysis has gotten pretty complicated, and code even more so.

It would be useful to create a formal specification for the analysis and validate all the cases with the current implementation. It might not be the worst idea to refactor the code to mimic the formal analysis more closely.
@arora-aman arora-aman self-assigned this Jun 30, 2021
@arora-aman
Copy link
Member Author

https://hackmd.io/D3I_gwvuT-SPnJ22tgJumw

@arora-aman arora-aman mentioned this issue Jul 9, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 11, 2021
@bors
Auto merge of rust-lang#86995 - sexxi-goose:rewrite, r=nikomatsakis
81053b9 
2229: Rewrite/Refactor Closure Capture Analaysis

While handling all the differnet edge cases the code for the captur analysis got pretty compicated. Looking at the overall picture of the edge cases the rules can still be layed out simply.

Alogithm: https://hackmd.io/D3I_gwvuT-SPnJ22tgJumw

r? `@nikomatsakis`

Closes rust-lang/project-rfc-2229#52
Implementation part of rust-lang/project-rfc-2229#53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arora-aman arora-aman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arora-aman