Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion to constants #15

Closed
celinval opened this issue Jul 29, 2023 · 10 comments
Closed

Add conversion to constants #15

celinval opened this issue Jul 29, 2023 · 10 comments
Milestone
StableMIR 0.1

Comments

@celinval
Copy link
Contributor

celinval commented Jul 29, 2023 •
edited by rustbot
Loading

Implement the translation MIR -> SMIR for constants.
@celinval celinval added this to the StableMIR 0.1 milestone Jul 29, 2023
@ouz-a
Copy link

ouz-a commented Aug 1, 2023 •
edited
Loading

@rustbot claim

Edit: Since bot doesn't work I'm going to work on this

@oli-obk
Copy link
Contributor

oli-obk commented Aug 1, 2023

The bot doesn't work yet

@ouz-a
Copy link

ouz-a commented Aug 1, 2023

Ah, okay 😅

@celinval
Copy link
Contributor Author

celinval commented Aug 1, 2023 •
edited
Loading

@ouz-a I assigned you for now.

This was referenced Aug 1, 2023
Closed
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#114466 - ouz-a:smir_allocation, r=oli-obk
fc6d74d 
Add Allocation to SMIR

As it's discussed [here ](https://rust-lang.zulipchat.com/#narrow/stream/320896-project-stable-mir/topic/Representing.20Constants.20in.20smir)this is an attempt to cover Constants for smir in a different way compared to rust-lang#114342

cc rust-lang/project-stable-mir#15

r? `@oli-obk`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#114466 - ouz-a:smir_allocation, r=oli-obk
92c0421 
Add Allocation to SMIR

As it's discussed [here ](https://rust-lang.zulipchat.com/#narrow/stream/320896-project-stable-mir/topic/Representing.20Constants.20in.20smir)this is an attempt to cover Constants for smir in a different way compared to rust-lang#114342

cc rust-lang/project-stable-mir#15

r? ``@oli-obk``
@ouz-a ouz-a mentioned this issue Aug 7, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#114587 - ouz-a:smir_allocation, r=oli-obk
bbc1109 
Convert Const to Allocation in smir

Continuation of previous pr rust-lang#114466

cc rust-lang/project-stable-mir#15

r? `@oli-obk`
@ouz-a
Copy link

ouz-a commented Aug 11, 2023

I think we can close this issue now.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2023

Lots of parts are still opaque, so we can leave this open to handle the opaque parts.

@ouz-a
Copy link

ouz-a commented Aug 29, 2023

As this is merged only thing other than Prov that left Opaque is this.
https://github.com/rust-lang/rust/blob/master/compiler/rustc_smir/src/stable_mir/ty.rs#L433

@ericmarkmartin
Copy link

@rustbot claim

@rustbot rustbot assigned ericmarkmartin and unassigned ouz-a Aug 31, 2023
@ericmarkmartin
Copy link

Whoops I accidentally claimed the wrong issue

@rustbot release-assignment

@celinval
Copy link
Contributor Author

celinval commented Mar 1, 2024

I believe we can close this now.

@celinval celinval closed this as completed Mar 1, 2024
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
@matthiaskrgr
Rollup merge of #114587 - ouz-a:smir_allocation, r=oli-obk
023d2ba 
Convert Const to Allocation in smir

Continuation of previous pr rust-lang/rust#114466

cc rust-lang/project-stable-mir#15

r? `@oli-obk`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@matthiaskrgr
Rollup merge of #114587 - ouz-a:smir_allocation, r=oli-obk
f218af1 
Convert Const to Allocation in smir

Continuation of previous pr rust-lang/rust#114466

cc rust-lang/project-stable-mir#15

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
StableMIR 0.1
Development

No branches or pull requests
4 participants
@oli-obk @ericmarkmartin @celinval @ouz-a