-
Notifications
You must be signed in to change notification settings - Fork 529
Are those Reference parts completely wrong/outdated? #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For the qualified path patterns, that is indeed not updated, and is tracked in #631. For the HRTB validation, that looks like a bug in rustc to me. It looks like it changed in rust-lang/rust#84682. I can't offhand think of a HRTB that would inherently be false, so I'm not sure what the original text was referring to. For the lazy boolean drop scope, it looks like that changed in rust-lang/rust#103293 but the reference was never updated. |
Can the reference part of qualified path patterns be quickfixed or rather it should be done as a part of whole "type_alias_enum_variants documentation" (as stated in #631)? I'm asking because I'm planning to propose some reference fixes and improvements in near future and I may include it. |
It's fine to make incremental progress. Just keep in mind that it is very helpful to point to the reasoning why something changed (like an RFC, stabilization report, or a PR description), and bonus points if you can point to the compiler tests that exhibit the change and the location in the compiler where the relevant behavior is implemented. |
How about this? ->
<Enum>::A
Couldn't this be used as a qualified path pattern, for example in match arms?
This below is not checked on definition:
And this is checked on definition:
So it looks like bounds that don't use the item's parameters are checked on definition, but higher-ranked lifetimes are not.
It looks like LHS is a temporary scope, too.
Playground example provided by @CAD97 from rust.internals
(forum discussion)
The text was updated successfully, but these errors were encountered: