-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document comparison used with limits #820
Comments
Specifically, how has the comparison changed? Which sentences are now wrong? |
No sentences are now wrong, but sentences could be added which describe that any values within the compiler are considered within the limit if they are less than or equal to the limit (previously this was inconsistent, sometimes less than, sometimes less than or equal). |
What about the code examples? Do they compile with the changed code? |
The first example still fails as expected (though I had to add semicolons after each of the macro expansions when running with rust-lang/rust#72540 locally - so that example will probably need updated at some point). The second example failed with a different error than on the reference, but still due to recursion limits:
The third example still fails as expected. |
rust-lang/rust#72540 makes sure that all comparisons against limits in the compiler are consistent, this should be documented in doc.rust-lang.org/reference/attributes/limits.html. rust-lang/rust#72540 should land before this is documented.
The text was updated successfully, but these errors were encountered: