Add \r\n to string_continue grammar
#1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think I would prefer to add a holistic solution for CRLF normalization instead of trying to address individual places. There are various points noted in #626 about CRLF normalization (and bare CR handling) that should probably be added as a whole (I believe per rust-lang/rust#62865 that it is translated globally, but I haven't investigated in a long while). |
|
makes sense, it was just that having only the |
Merged
|
Closing as superseded by #1459. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is necessary, but I wasn't 100% sure that crlf line endings would be supported (though in hindsight would be strange if they weren't)