Remove broken footnote links from grammar summary #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
traviscross
force-pushed
the
TC/remove-broken-footnotes-from-grammar-summary
branch
from
6148182 to
5207470
Compare
traviscross
changed the title
traviscross
force-pushed
the
TC/remove-broken-footnotes-from-grammar-summary
branch
from
5207470 to
bb9245f
Compare
ehuss
approved these changes
Apr 17, 2025
traviscross
force-pushed
the
TC/remove-broken-footnotes-from-grammar-summary
branch
from
bb9245f to
1bbec1c
Compare
Our grammar syntax supports linking to footnotes which we render in the Markdown version. This works when the rendering is done on the same page that the footnote appears. On the grammar summary page, however, where we also render the grammar, these footnotes are not present, and so the links were all broken. Let's fix this for now by not rendering these footnote links on the grammar summary page.
traviscross
force-pushed
the
TC/remove-broken-footnotes-from-grammar-summary
branch
from
1bbec1c to
eefaabb
Compare
traviscross
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our grammar syntax supports linking to footnotes which we render with the Markdown version. This works when the rendering is done on the same page that the footnote appears.
On the grammar summary page, however, where we also render the grammar, these footnotes are not present, and so the links were all broken.
Let's fix this for now by not rendering these footnote links on the grammar summary page.