Remove outdated comment about non-copy unions #1872
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure when exactly this was removed, but non-copy union fields aren't allowed, and there is no nightly feature to allow them AFAIK. There was various discussion in the tracking issue rust-lang/rust#55149 and various changes like rust-lang/rust#97995 on what is allowed, but I did not dig down to find the exact change that closed the door. The allowed field kinds are described in items.union.field-restrictions. Also, in general the reference shouldn't be referring to unstable features.
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when exactly this was removed, but non-copy union fields aren't allowed, and there is no nightly feature to allow them AFAIK.
There was various discussion in the tracking issue rust-lang/rust#55149 and various changes like rust-lang/rust#97995 on what is allowed, but I did not dig down to find the exact change that closed the door.
The allowed field kinds are described in items.union.field-restrictions.
Also, in general the reference shouldn't be referring to unstable features.