Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that literals with any suffixes are valid as tokens #612

Merged
merged 3 commits into from
May 31, 2019

Conversation

petrochenkov
Copy link
Contributor

src/tokens.md Show resolved Hide resolved
src/tokens.md Outdated Show resolved Hide resolved
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Centril Centril merged commit f8ae436 into rust-lang:master May 31, 2019
@ehuss
Copy link
Contributor

ehuss commented May 31, 2019

That section isn't really intended to be the definition, but is rather just a list of examples. Perhaps it should be reorganized since others have been a bit confused by it.

I would think there also needs to be some updates to the Lexer definitions to cover this. It's unfortunate that this makes essentially two sets of literals, but perhaps just a consolidated section could be created to cover "macro tokens".

I can work on rearranging this some time soonish, but I wouldn't consider this resolved.

@Centril
Copy link
Contributor

Centril commented Jun 1, 2019

@ehuss Could you file an issue meanwhile?

@petrochenkov
Copy link
Contributor Author

Yeah, a new reference issue, not reopening that lang issue.
I wasn't too happy about the structure of src/tokens.md either, but I also wasn't ready for doing a larger rewrite.

bors added a commit to rust-lang/rust that referenced this pull request Jun 8, 2019
Update books

## reference

2 commits in 862b669..f8ae436
2019-05-04 23:41:35 -0700 to 2019-05-31 14:59:12 +0200
- Document that literals with any suffixes are valid as tokens (rust-lang/reference#612)
- Fix example code of derive macro (rust-lang/reference#611)

## book

2 commits in 29fe982990e43b9367be0ff47abc82fb2123fd03..62a8c6f25fbd981c80a046f3b04be9684749af3b
2019-05-15 17:48:40 -0400 to 2019-05-28 15:48:23 -0400
- Remove snapshots checked in layout
- Remove snapshots that I've approved in layout

## rust-by-example

5 commits in 811c697b232c611ed754d279ed20643a0c4096f6..18566f4dedc3ef5bf61f5f85685d5966db99cc11
2019-04-28 18:56:42 -0300 to 2019-05-30 19:23:24 -0300
- Fixed wording in the `Seconds` struct description. (rust-lang/rust-by-example#1195)
- Fix usage of the word "elision" (rust-lang/rust-by-example#1191)
- Reword "Flow Control" to "Flow of Control" (rust-lang/rust-by-example#1190)
- Copy edits to chapter 1 (rust-lang/rust-by-example#1189)
- Fix typo in a mod/visibility.md (rust-lang/rust-by-example#1188)

## rustc-guide

9 commits in 3cb727b..3ac9cfc
2019-05-07 09:53:32 -0500 to 2019-06-02 19:36:58 -0500
- Update information about debuginfo configuration
- fix long line
- Fixed misspelling
- Add more info subsection with links to forge and rustc api docs (rust-lang/rustc-dev-guide#324)
- Renamed the file and title of the diagnostics chapter.
- Added rustc phases diagram and explanation
- Mention running tests for subdirectories
- Fixed links broken by merging chalks rules and solve
- Add documentation about profile-guided optimization.

## embedded-book

1 commits in 9858872bd1b7dbba5ec27dc30d34eba00acd7ef9..f0c75b75f9c18537b78f5d17c1015247e9a49c86
2019-05-02 18:56:54 +0000 to 2019-06-03 10:49:02 +0000
- Qemu md changes  (rust-embedded/book#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suffixed string and char literals are accepted if they don't go through parser
3 participants