Fix stable check. #885
Closed
Fix stable check. #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
reviewed
Sep 15, 2020
| } else { | ||
| let mut file = File::open(&path)?; | ||
| let mut contents = String::new(); | ||
| file.read_to_string(&mut contents)?; |
There was a problem hiding this comment.
You could use fs::read_to_string.
There was a problem hiding this comment.
Yea, I noticed that, too. I rewrote it in #886.
|
Have you tested that your change works locally? |
|
Yea, I've tested that this works as expected. However, #886 is a superset of this, and I would prefer to merge that instead. Do you think you can review that PR? |
|
I presume this should be closed due to #886. If not, reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stable check was stopping at the first directory it found.