-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regex-automata v0.3.2: test failures on 32-bit architectures #1039
Comments
build.log (it appears that uploading the log as an attachment works better) |
One of these tests (the captures one) is very specific to 64-bit since it uses a numeric literal that is bigger than what can be fit into 32 bits. The other two tests, for determinize_size_limit, are not specific to 64-bit targets but do somewhat depend on the specific memory usages in play. We could probably find some limits that work for both 32-bit and 64-bit, but since 'cross' doesn't run doc tests, doing this is pretty annoying. So just ignore the tests. Fixes #1039
Thankfully all of these failures are benign. I've put up #1040 to just skip these tests on non-64-bit. The thornier issue here is that |
Thanks for looking into it! I'll just skip those three doctests on 32-bit x86 for now if they're harmless. 👍🏼 |
Yup it's basically just a matter of the doc tests exercising the effects of certain limits on heap usage. 32 and 64 bit will vary there and thus the limits just have different effects. And the capture group one is harmless for the reason you point out: it only exercises a case that fails in 64-bit. |
One of these tests (the captures one) is very specific to 64-bit since it uses a numeric literal that is bigger than what can be fit into 32 bits. The other two tests, for determinize_size_limit, are not specific to 64-bit targets but do somewhat depend on the specific memory usages in play. We could probably find some limits that work for both 32-bit and 64-bit, but since 'cross' doesn't run doc tests, doing this is pretty annoying. So just ignore the tests. Fixes #1039
I'm trying to update the Fedora Linux packages for the regex crate and its dependencies to the latest version, but I'm getting stuck on test failures on 32-bit x86 (i.e. i686-unknown-linux-gnu). Unit tests seem to be fine, but some doctests fail:
The first two failures produce absolutely gigantic log output on failure, I've pasted the complete output of "cargo test" in a Gist here (though GitHub seems to cut off the content after only 12,000 of 19,000 lines): https://gist.github.com/decathorpe/a5e715d566c5b75838ccd1fbfd4cf4fa
But the gist (pun intended) seems to be:
and
The third failure is a simple one (numeric literal too large for usize, which is typically only 32-bit integer on 32-bit architectures):
The text was updated successfully, but these errors were encountered: