Remove all public reexports #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're leftovers from the enum namespacing transition Other than removing public reexports, I also had to publicize a type (compile::InstIdx). It should have always been public but no error was ever given because of this bug: rust-lang/rust#6477 I also had to enable documentation for compile::Ist because it was complaining that there wasn't any.
frewsxcv
force-pushed
the
rm-reexports
branch
from
3e0db5e
to
7565337
Compare
|
Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Dec 24, 2014
Remove all public reexports
BurntSushi
pushed a commit
that referenced
this pull request
Nov 17, 2021
This fixes the oss-fuzz build.
Specifically, the build log[1] showed this error:
Step #3 - "compile-libfuzzer-address-x86_64": error: inherits must
not be specified in root profile dev
So we just remove it and inline the settings.
PR #817
[1] - https://oss-fuzz-build-logs.storage.googleapis.com/log-c9b61873-8950-4a50-a729-820d5617ff7a.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're leftovers from the enum namespacing transition
Other than removing public reexports, I also had to publicize a type
(compile::InstIdx). It should have always been public but no
error was ever given because of this bug:
rust-lang/rust#6477
I also had to enable documentation for compile::Ist because it was
complaining that there wasn't any.