Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation errors #51

Merged
merged 1 commit into from
Mar 4, 2015
Merged

Fixed compilation errors #51

merged 1 commit into from
Mar 4, 2015

Conversation

gchp
Copy link
Contributor

@gchp gchp commented Mar 4, 2015

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@gchp
Copy link
Contributor Author

gchp commented Mar 4, 2015

I currently can't compile regex. See this comment for info: #50 (comment)

@BurntSushi
Copy link
Member

I get the same over here. I ran it under valgrind:

 valgrind rustc src/lib.rs --crate-name regex --crate-type lib -g -C metadata=64952606b89c7990 -C extra-filename=-64952606b89c7990 --out-dir /home/andrew/data/projects/rust/regex/target --emit=dep-info,link -L dependency=/home/andrew/data/projects/rust/regex/target -L dependency=/home/andrew/data/projects/rust/regex/target/deps

and got this: https://gist.github.com/087f0afda9e422cd44b1 --- bug in rustc? This is all the investigation I can do at the moment though. :-(

@BurntSushi
Copy link
Member

@alexcrichton ping. :-)

@alexcrichton
Copy link
Member

Hm, fascinating! Looks like rust-lang/rust#23032 has the segfault issue covered and the changes in #52 don't cause a segfault, so I'll merge that for now.

@alexcrichton alexcrichton merged commit 056a21d into rust-lang:master Mar 4, 2015
@alexcrichton
Copy link
Member

Thanks regardless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants