(#521, #627) Fixes for split() and splitn() #628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects `/-/.split("a-")` to return `["a", ""]` correctly instead of `["a"]`.
(`/-/` is shorthand for `Regex::new("-").unwrap()`.)
This adds tests for both `split()` and `splitn()` covering a variety of
edge cases. One test is commented out because it is failing due to #521.
A future commit will fix it.
Note that the `split2` and `split3` tests were passing incorrectly
before this change. I have fixed them to expect the correct values.
Corrects `/-/.splitn("a", 2)` to return `["a"]` correctly instead of
`["a", ""]`. (`/-/` is shorthand for `Regex::new("-").unwrap()`.)
Closed
Contributor
Author
|
The CI failure is only for Rust “stable.” It appears to be unrelated to the changes in this PR. https://travis-ci.com/rust-lang/regex/jobs/257680677 |
Contributor
Author
|
CI failure issue #634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/-/.split("a-")to return["a", ""]correctly instead of["a"]./-/.splitn("a", 2)to return["a"]correctly instead of["a", ""].Note that a couple of existing tests (
split2andsplit3) were passing incorrectly before these changes.I’m using
/-/as a short hand forRegex::new("-").unwrap(). It seems clear enough, but then I’ve written a lot of code in languages with regex literals.This supersedes PR #606 which attempted to fix #521.
I disclaim ownership of these changes. They are owned by whoever owns the bulk of the rest of the code. (I am not a lawyer, but I’ll head them off at the pass if I can.)