Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permit "rfcbot resolve foo" as an alias #193

Closed
nikomatsakis opened this issue Mar 20, 2018 · 2 comments
Closed

permit "rfcbot resolve foo" as an alias #193

nikomatsakis opened this issue Mar 20, 2018 · 2 comments

Comments

@nikomatsakis
Copy link
Contributor

I confess, I can never remember the syntax around concerns. I would appreciate a few aliases. Here are some things I commonly try:

  • @rfcbot resolve foo
  • @rfcbot fcp resolve foo

Alternatively, a message from the bot when it sees a command it does not understand would be nice. Something like:


Dear @nikomatsakis,

I am but a simple bot and I am afraid I do not understand what you want of me. Perhaps you could try one of the following commands?

  • rfcbot fcp merge
  • rfcbot concern foo
  • rfcbot resolve foo
  • ...

Actually, I just want both. =)

@anp
Copy link
Member

anp commented Mar 20, 2018

The first thing you listed should already work, but I haven't tested it: https://github.com/anp/rfcbot-rs/blob/master/src/github/nag.rs#L810 (I left that TODO in there because I couldn't remember what "correct tokenization" meant and it looks like that code should work).

I definitely agree that this would be really valuable to have.

@Centril
Copy link
Contributor

Centril commented May 3, 2018

This is implemented now, so let's close this issue?

@anp anp closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants