Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify majority/consensus criteria #258

Closed
dwijnand opened this issue Jan 27, 2019 · 1 comment
Closed

Clarify majority/consensus criteria #258

dwijnand opened this issue Jan 27, 2019 · 1 comment

Comments

@dwijnand
Copy link
Member

As of #188, the current FCP proposed comment says "Once a majority of reviewers approve (and none object)" and the conditions are num_active_concerns == 0 && num_outstanding_reviews < num_complete_reviews && num_outstanding_reviews < 3.

In an proposal in cargo, the contributor thought it was strict majority: rust-lang/cargo#6535 (comment).

Could the messaging be improved?

@jethrogb
Copy link

jethrogb commented Jan 27, 2019

Looks like the common case is "Once all but 2 reviewers approve". Only if the reviewer set size is 4 or less is it "Once a majority of reviewers approve". (Either statement is correct for sizes 5-6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants