Clarify what consensus/majority means #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is what I suggested exactly, this is now wrong for reviewer set sizes under 5. |
|
I need to check the code again, but aren’t we looking for a quorum here, not a specific number? |
dwijnand
force-pushed
the
clarify-consensus
branch
from
2f0669a to
a9f0cc5
Compare
|
This looks correct... but there are travis failures for unrelated reasons :( |
|
No it's wrong now, it should be "at most 2" |
dwijnand
force-pushed
the
clarify-consensus
branch
from
a9f0cc5 to
586d679
Compare
|
Ugh, 2 strikes. 3rd time's the charm? Thanks, @jethrogb... |
dwijnand
force-pushed
the
clarify-consensus
branch
from
586d679 to
d313f30
Compare
|
This is just a messaging tweak. Can it be merged without CI validation passes, @anp? I can drop the rust-toolchain update commit if need be. |
dwijnand
force-pushed
the
clarify-consensus
branch
from
d313f30 to
fb63e95
Compare
|
Let's run this through travis again :) |
|
✅! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you, @jethrogb, for the suggestion!
Fixes #258