-
Notifications
You must be signed in to change notification settings - Fork 64
[Needs review] Feature: @rfcbot poll [teams] #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
155e428
add itertools as dependency.
Centril 1814249
add database model for Poll stuff.
Centril dd221a4
really add itertools as dependency in main.rs.
Centril 1e9814b
teams: expose test data, change team names a bit, expose ping and nam…
Centril c5d769c
refactor a bunch of logic and implement polling (hopefully...).
Centril 60ae53f
update command grammar in README.md.
Centril cd230f8
fix syntax error in up.sql migration.
Centril 5b69176
fix copy error in up.sql migration.
Centril fffdbd6
fix typo in up.sql migration.
Centril 97a4b26
close poll when everyone has answered it.
Centril 0de4780
fix #212 by filtering in unstarted fcps. (#223)
Centril 59dc131
Update toolchain and lockfile (#232)
Centril ea67451
Add Centril to the lang team (#230)
joshtriplett ef63384
fix typos (quized -> quizzed).
Centril 90de0d2
Merge remote-tracking branch 'upstream/master' into feature/poll-team-2
Centril 7990d27
fix 225, and deal with leading whitespace.
Centril 437d7a2
colocate from_invocation_line and from_str_all.
Centril 4810f33
get rid of global state from command parser.
Centril 9a7a94a
review -> response for polls.
Centril 6fabf31
fix comments.
Centril b5916fb
make progress on all 3 in evaluate_nags.
Centril 4b5ecc2
RfcBotCommand::{AskQuestion -> StartPoll}.
Centril 5a1d5dd
gracefully handle poll comment typos.
Centril 8e87361
fix bug.
Centril File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| DROP TABLE poll; | ||
| DROP TABLE poll_review_request; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| CREATE TABLE poll ( | ||
| id SERIAL PRIMARY KEY, | ||
| fk_issue INTEGER UNIQUE NOT NULL REFERENCES issue (id), | ||
| fk_initiator INTEGER NOT NULL REFERENCES githubuser (id), | ||
| fk_initiating_comment INTEGER NOT NULL REFERENCES issuecomment (id), | ||
| fk_bot_tracking_comment INTEGER NOT NULL REFERENCES issuecomment (id), | ||
| poll_question VARCHAR NOT NULL, | ||
| poll_created_at TIMESTAMP, NOT NULL, | ||
| poll_closed BOOLEAN NOT NULL, | ||
| poll_teams VARCHAR NOT NULL | ||
| ); | ||
|
|
||
| CREATE TABLE poll_review_request ( | ||
| id SERIAL PRIMARY KEY, | ||
| fk_poll INTEGER NOT NULL REFERENCES fcp_proposal (id) ON DELETE CASCADE, | ||
| fk_reviewer INTEGER NOT NULL REFERENCES githubuser (id), | ||
| reviewed BOOLEAN NOT NULL, | ||
| UNIQUE (fk_proposal, fk_reviewer) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.