Skip to content

Commit

Permalink
drawbacks update
Browse files Browse the repository at this point in the history
  • Loading branch information
newpavlov committed Jul 4, 2018
1 parent 800825c commit 4ec9682
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions text/0000-min-rust-version.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,12 @@ max `version` value from them as a MSRV. If all `cfg`s are false, value in the
# Drawbacks
[drawbacks]: #drawbacks

- Declaration of MSRV and describe checks does not guarantee that, only
appropriate CI testing.
- Declaration of MSRV, even with the checks, does not guarantee that crate
will work correctly on the specified MSRV, only appropriate CI testing can do that.
- More complex dependency versions resolution algorithm.
- MSRV selected by `cargo publish` can be overly conservative.
- MSRV checks will make compiler more complex.
- MSRV selected by `cargo publish` with `rust = "stable"` can be too
conservative.
- Checking `#[stable(since=version)]` of used items will make compiler more complex.

# Rationale and Alternatives
[alternatives]: #alternatives
Expand Down

0 comments on commit 4ec9682

Please sign in to comment.